From ef99dc9a636e38f7626156c3d3e4b80e285547f8 Mon Sep 17 00:00:00 2001 From: jacksonfu14 Date: Tue, 18 Nov 2025 07:08:34 +0100 Subject: modify sequence to ly conversion --- morphology-img/src/note.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'morphology-img/src/note.rs') diff --git a/morphology-img/src/note.rs b/morphology-img/src/note.rs index 98dbd68..c2158a3 100644 --- a/morphology-img/src/note.rs +++ b/morphology-img/src/note.rs @@ -92,20 +92,29 @@ impl Duration { /// In future iterations, duration may be derived from additional meta-affine structures. /// /// Transformation steps: -/// 1. Convert (outer, inner) pairs to integers: pitch = (outer * length) + inner +/// 1. Convert (outer, inner) pairs to integers: pitch = (outer * multiplier) + inner +/// where multiplier = max(abs(inner values)) + 3 /// 2. Convert integers to pitch names using integer_to_pitch_name /// 3. Append quarter note duration to create notes /// /// # Arguments /// - `sequence`: The meta-affine sequence to convert pub fn sequence_to_notes(sequence: &morphology::Sequence) -> Vec { - let length = sequence.length() as i32; let duration = Duration::QUARTER; + // Find the maximum absolute value of inner values + let max_abs_inner = sequence.values() + .iter() + .map(|value| value.inner.abs()) + .max() + .unwrap_or(0); + + let multiplier = max_abs_inner + 3; + sequence.values() .iter() .map(|value| { - let pitch_int = (value.outer * length) + value.inner; + let pitch_int = (value.outer * multiplier) + value.inner; let pitch = integer_to_pitch_name(pitch_int); LilyPondNote::new(pitch, duration) }) -- cgit v1.2.3